feat:Including import credentials for project via secretRef #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
abacus3
reviewed
Apr 29, 2024
MisterMX
requested changes
May 13, 2024
Comment on lines
+184
to
+187
| - password | ||
| - secretName | ||
| - secretNamespace | ||
| - username |
There was a problem hiding this comment.
Are username and password required values or should the provider support imports from public repos?
There was a problem hiding this comment.
username and password are required only if importUrlSecretRef is not nil. And yes the provider should also support imports from public repos. @abacus3
There was a problem hiding this comment.
OK, thank. I think the name importUrlSecretRef´ is a bit misleading. Can we change it to something more explicit like importCredentialsSecretRef`?
|
@frkouokam once this PR is ready to be merged can set it to "Ready for Review" and squash your changes into a single commit and sign it off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
API definition for secretRef has been added in project_types.go.
Retrieving secret and adding it to the importUrl has been implemented in controller/project.go (WIP)
Fixes #48
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested