Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing logger #151

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

BigGold1310
Copy link
Contributor

Description of your changes

Add a default no-op logger so that the controller-runtime isn't producing a stack trace.
Other providers are already using the same solution to avoid this problem:

Fixes #150

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually built & run test suite.

Signed-off-by: Cyrill Näf <[email protected]>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @BigGold1310

@MisterMX MisterMX merged commit 4d3cc79 into crossplane-contrib:master Jul 24, 2024
8 checks passed
Copy link

Successfully created backport PR #152 for release-0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No logs in Pod - [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
2 participants