Bump v1beta1 with a Conversion Webhook for Management Policies #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Looks like we need to have at least v1beta1 for conversion,
otherwise getting:
invalid: spec.conversion.conversionReviewVersions: Invalid value: []string{"v1alpha2"}: must include at least one of v1, v1beta1
Signed-off-by: Hasan Turken <[email protected]>
turkenh
force-pushed
the
bump-v1beta1
branch
from
9190592 to
45f4834
Compare
turkenh
requested review from
morningspace
and removed request for
morningspace
lsviben
reviewed
Nov 16, 2023
Comment on lines
+20
to
+21
| case ObserveCreateUpdate: | ||
| dst.Spec.ManagementPolicies = xpv1.ManagementPolicies{xpv1.ManagementActionObserve, xpv1.ManagementActionCreate, xpv1.ManagementActionUpdate} |
There was a problem hiding this comment.
Should we include LateInitialize here? What was the default behaviour of ObserveCreateUpdate, did it do some LateInitialization?
Comment on lines
+54
to
+55
| // TODO(turkenh): Should we default to something here instead of erroring out? | ||
| return errors.New("unsupported management policy") |
There was a problem hiding this comment.
We could play it safe and make it observe-only but still it would be good to inform the users somehow that it happened.
I would be ok with erroring out to make it simple
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2020 The Crossplane Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2020 The Crossplane Authors. | |
| Copyright 2023 The Crossplane Authors. |
some other places as well
| // Package type metadata. | ||
| const ( | ||
| Group = "kubernetes.crossplane.io" | ||
| Version = "v1alpha1" |
There was a problem hiding this comment.
Suggested change
| Version = "v1alpha1" | |
| Version = "v1beta1" |
Comment on lines
+31
to
+54
| // A ManagementPolicy determines what should happen to the underlying external | ||
| // resource when a managed resource is created, updated, deleted, or observed. | ||
| // +kubebuilder:validation:Enum=Default;ObserveCreateUpdate;ObserveDelete;Observe | ||
| type ManagementPolicy string | ||
|
|
||
| const ( | ||
| // Default means the provider can fully manage the resource. | ||
| Default ManagementPolicy = "Default" | ||
| // ObserveCreateUpdate means the provider can observe, create, or update | ||
| // the resource, but can not delete it. | ||
| ObserveCreateUpdate ManagementPolicy = "ObserveCreateUpdate" | ||
| // ObserveDelete means the provider can observe or delete the resource, but | ||
| // can not create and update it. | ||
| ObserveDelete ManagementPolicy = "ObserveDelete" | ||
| // Observe means the provider can only observe the resource. | ||
| Observe ManagementPolicy = "Observe" | ||
|
|
||
| // ObjectActionCreate means to create an Object | ||
| ObjectActionCreate ObjectAction = "Create" | ||
| // ObjectActionUpdate means to update an Object | ||
| ObjectActionUpdate ObjectAction = "Update" | ||
| // ObjectActionDelete means to delete an Object | ||
| ObjectActionDelete ObjectAction = "Delete" | ||
| ) |
There was a problem hiding this comment.
should this be removed for v1beta1?
| - jsonPath: .metadata.creationTimestamp | ||
| name: AGE | ||
| type: date | ||
| name: v1alpha2 |
|
@lsviben as we discussed offline, please continue with a new PR as it will make things easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
WIP to bump Object API from v1alpha1 to v1beta1 with a conversion webhook for migrating
spec.managementPolicyto XP runtime'sspec.managementPoliciesFixes: #162
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
WIP