Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitter to poll interval #198

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

ravilr
Copy link
Contributor

@ravilr ravilr commented Feb 13, 2024

Description of your changes

  • Adds a +/-10% jitter to Object's reconcile delay, helps towards spreading out requeue'ing of resources and minimize the likelihood of running into K8s client qps/burst limits.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • make test and make e2e

  • below graph shows the before(blue plot) and after(green plot) effect of this change on reconciliation rate of Object resources running with poll-interval=5m and poll-jitter=30s:

Screenshot 2024-02-10 at 2 11 49 PM

@ravilr
Copy link
Contributor Author

ravilr commented Feb 13, 2024

@lsviben @turkenh PTAL 🙏

Copy link
Collaborator

@lsviben lsviben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravilr ! LGTM

cmd/provider/main.go Outdated Show resolved Hide resolved
@lsviben lsviben merged commit 74fc861 into crossplane-contrib:main Feb 16, 2024
8 checks passed
@ravilr ravilr deleted the poll_jitter branch February 16, 2024 19:31
@ravilr
Copy link
Contributor Author

ravilr commented Feb 16, 2024

@lsviben just checking when is the next planned release for this provider ? Interested in this and #193 included in a release. Thanks.

@turkenh
Copy link
Collaborator

turkenh commented Feb 19, 2024

@ravilr doing some performance/load testing with this provider.
I hope to have a release with some improvements from there later this week or early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants