-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add v0.16.0 package new address #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this update @Mathges! I think we can just make the change all the way instead of just a comment 😉
Can you also sign-off your commit? details for that can be found in https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin.
README.md
Outdated
@@ -26,6 +26,7 @@ metadata: | |||
name: provider-kubernetes | |||
spec: | |||
package: xpkg.upbound.io/crossplane-contrib/provider-kubernetes:v0.13.0 | |||
# package: xpkg.upbound.io/upbound/provider-kubernetes:v0.16.0 for v0.16.0 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd say we can just make this update completely, as opposed to adding a new commented line. that's the new location and we'd like folks to be installing the latest, so let's just update these references to the most newest location/version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it installed OK/healthy for me 😇
❯ k get pkg
NAME INSTALLED HEALTHY PACKAGE AGE
provider.pkg.crossplane.io/provider-kubernetes True True xpkg.upbound.io/upbound/provider-kubernetes:v0.16.0 48m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also a reference using crossplane xpkg install
a few lines above, you can make that update too as part of this PR:
crossplane xpkg install provider xpkg.upbound.io/upbound/provider-kubernetes:v0.16.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey !
Normally it should be OK now, lemme know if there is anything else !
Signed-off-by: Mathieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the quick follow up. This looks good to me! The CI pipeline is running now and if it's green I'll merge 😉
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
As it is only 2 comments in noon running code I took liberty to not run any test, except I installed provider-kubernetes using package address mentionned in commentaries
I wait for any review to check the "run make reviewable test" checkbox
Feel free to point me anywhere I have to change also (especially for the console address, I haven't tested it)