-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure AD authentication support for mssql #166
base: master
Are you sure you want to change the base?
Conversation
Would you mind rebasing? |
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
@Duologic i've rebased it |
Any updates on this @Mikel-Landa @Duologic ? Would be nice to get this merged! |
@Mikel-Landa This change looks promising and would cover a requirement, where I'd like to allow AD users temporary access to the database. |
This might need another rebase, and don't forget to sign the commits. |
Description of your changes
Fixes #165
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Created a local cluster and connected to an existing database. Tested a creation of a database, user and grant and then connected through ad to the database with the provisioned user