Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure AD authentication support for mssql #166

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Mikel-Landa
Copy link

Description of your changes

Fixes #165

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Created a local cluster and connected to an existing database. Tested a creation of a database, user and grant and then connected through ad to the database with the provisioned user

NAME                                             READY   SYNCED   AGE
database.mssql.sql.crossplane.io/example-db-ad   True    True     96m

NAME                                          READY   SYNCED   AGE   ROLE          DATABASE        PERMISSIONS
grant.mssql.sql.crossplane.io/example-grant   True    True     7s    ***@***.com   example-db-ad   ["CONNECT","CREATE TABLE","INSERT","SELECT"]

NAME                                           READY   SYNCED   AGE
user.mssql.sql.crossplane.io/example-user-ad   True    True     93s

@Duologic
Copy link
Member

Would you mind rebasing?

Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
@Mikel-Landa
Copy link
Author

@Duologic i've rebased it

@eegseth
Copy link

eegseth commented Sep 16, 2024

Any updates on this @Mikel-Landa @Duologic ? Would be nice to get this merged!

bakito added a commit to bakito/provider-sql that referenced this pull request Nov 12, 2024
@bakito
Copy link
Contributor

bakito commented Dec 5, 2024

@Mikel-Landa This change looks promising and would cover a requirement, where I'd like to allow AD users temporary access to the database.
I installed your branch, but I could not get it running for my database.
Are there any specific setting that have to be defined on the database/database-server or ProviderConfig to get this working?

@Duologic
Copy link
Member

Duologic commented Dec 5, 2024

This might need another rebase, and don't forget to sign the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure AD authentication in mssql
4 participants