Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres FlexibleServer: Add password autogeneration capability #587

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Postgres FlexibleServer: Add password autogeneration capability #587

merged 2 commits into from
Nov 10, 2023

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Nov 9, 2023

Description of your changes

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make e2e UPTEST_EXAMPLE_LIST=examples/dbforpostgresql/flexibleserver-all-in-one.yaml
...
--- PASS: kuttl (674.33s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (659.54s)
PASS
00:18:10 [ OK ] running automated tests

In parallel to the test run I have validated that the automatically generated password was correctly propagated the referenced secret:

k view-secret -n upbound-system example-secret
Choosing key: example-key
mzgfGdPS68HdnErqIoSkCc4CsYb%

@ytsarev
Copy link
Collaborator Author

ytsarev commented Nov 9, 2023

/test-examples="examples/dbforpostgresql/flexibleserver-all-in-one.yaml"

turkenf
turkenf approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @ytsarev, I left a nit comment, lgtm.

config/postgresql/config.go Outdated Show resolved Hide resolved
@ytsarev ytsarev force-pushed the flexible-server-autogen-passowrd branch from a8260c3 to 7020c19 Compare November 10, 2023 12:26
@ytsarev ytsarev force-pushed the flexible-server-autogen-passowrd branch from 7020c19 to c9757c0 Compare November 10, 2023 12:49
@turkenf turkenf merged commit adf8b21 into crossplane-contrib:main Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenf turkenf turkenf approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autogenerate admin password
2 participants
@ytsarev @turkenf