Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrontdoorFirewallPolicy and FrontdoorSecurityPolicy to cdn group #600

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

Mikel-Landa
Copy link
Contributor

Description of your changes

Fixes #599

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've created the resources on a local kind cluster on my tenant. Resources have been created successfully.

➜ k get managed
NAME                                                     READY   SYNCED   EXTERNAL-NAME             AGE
resourcegroup.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
resourcegroup.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                                 READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorcustomdomain.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   7m19s

NAME                                                                   READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorfirewallpolicy.cdn.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
frontdoorfirewallpolicy.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                            READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorprofile.cdn.azure.upbound.io/frontdoorfirewallpolicy   True    True     frontdoorfirewallpolicy   34m
frontdoorprofile.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   37m

NAME                                                                   READY   SYNCED   EXTERNAL-NAME             AGE
frontdoorsecuritypolicy.cdn.azure.upbound.io/frontdoorsecuritypolicy   True    True     frontdoorsecuritypolicy   38m

NAME                                                       READY   SYNCED   EXTERNAL-NAME         AGE
dnszone.network.azure.upbound.io/frontdoorsecuritypolicy   True    True     upbound-example.com   5m11s

Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
@Upbound-CLA
Copy link

Upbound-CLA commented Dec 1, 2023

CLA assistant check
All committers have signed the CLA.

@Mikel-Landa
Copy link
Contributor Author

/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml,examples/cdn/frontdoorfirewallpolicy.yaml"

1 similar comment
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml,examples/cdn/frontdoorfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Dec 4, 2023

/test-examples="examples/cdn/frontdoorfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Dec 4, 2023

/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort in this PR @Mikel-Landa, LGTM.

@turkenf turkenf merged commit 6fb58f6 into crossplane-contrib:main Dec 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for azurerm_cdn_frontdoor_firewall_policy and azurerm_cdn_frontdoor_security_policy resources
4 participants