-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FrontdoorFirewallPolicy and FrontdoorSecurityPolicy to cdn group #600
Conversation
…roup to externalnames Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
…y in cdn group Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
Signed-off-by: Mikel Landa <[email protected]>
/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml,examples/cdn/frontdoorfirewallpolicy.yaml" |
1 similar comment
/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml,examples/cdn/frontdoorfirewallpolicy.yaml" |
/test-examples="examples/cdn/frontdoorfirewallpolicy.yaml" |
/test-examples="examples/cdn/frontdoorsecuritypolicy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your effort in this PR @Mikel-Landa, LGTM.
Description of your changes
Fixes #599
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I've created the resources on a local kind cluster on my tenant. Resources have been created successfully.