-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release-0.42] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies #657
[Release-0.42] Switch from the NoFork terminology to the TerraformPluginSDK terminology and bump dependiencies #657
Conversation
…ogy and bump dependiencies Signed-off-by: Fatih Türken <[email protected]>
52a5091
to
433abb8
Compare
/test-examples="examples/azure/resourcegroup.yaml" |
/test-examples="examples/network/subnet.yaml" |
/test-examples="examples/containerservice/kubernetescluster.yaml" |
/test-examples="examples/cdn/endpoint.yaml" |
/test-examples="examples/dbformysql/database.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf, lgtm. Let's fix the versions to the ones already defined in go.mod
:
replace golang.org/x/exp => golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa
replace github.com/hashicorp/terraform-json => github.com/hashicorp/terraform-json v0.16.0
replace github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
replace github.com/hashicorp/terraform-plugin-go => github.com/hashicorp/terraform-plugin-go v0.14.3
Let's also run at least one uptest again after these dependency changes.
/test-examples="examples/azure/resourcegroup.yaml" |
/test-examples="examples/network/subnet.yaml" |
/test-examples="examples/containerservice/kubernetescluster.yaml" |
Signed-off-by: Fatih Türken <[email protected]>
74013b5
to
3b84a77
Compare
/test-examples="examples/azure/resourcegroup.yaml" Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007139513 |
/test-examples="examples/network/subnet.yaml" Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007142159 |
/test-examples="examples/containerservice/kubernetescluster.yaml" Uptest run: https://github.com/upbound/provider-azure/actions/runs/8007145087 |
Description of your changes
In this PR:
v1.15.1
v1.1.1
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
examples/azure/resourcegroup.yaml
=> https://github.com/upbound/provider-azure/actions/runs/8004351909examples/network/subnet.yaml
=> https://github.com/upbound/provider-azure/actions/runs/8004357523examples/containerservice/kubernetescluster.yaml
=> https://github.com/upbound/provider-azure/actions/runs/8004355788examples/cdn/endpoint.yaml
=> https://github.com/upbound/provider-azure/actions/runs/8004359236examples/dbformysql/database.yaml
=> https://github.com/upbound/provider-azure/actions/runs/8004353517