-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azurerm_cognitive_deployment resource #706
Add azurerm_cognitive_deployment resource #706
Conversation
Signed-off-by: Mirza Esaaf Shuja <[email protected]>
Signed-off-by: Mirza Esaaf Shuja <[email protected]>
Signed-off-by: Mirza Esaaf Shuja <[email protected]>
Signed-off-by: Mirza Esaaf Shuja <[email protected]>
…xample Signed-off-by: Mirza Esaaf Shuja <[email protected]>
/test-examples="examples/cognitiveservices/deployment.yaml" |
@jeanduplessis Just noticed Quota Issue in the subscription configured for uptest. Account Name: "example-ca"): unexpected status 400 with error: SpecialFeatureOrQuotaIdRequired: The subscription does not have QuotaId/Feature required by SKU 'S0' from kind 'OpenAI' or contains blocked QuotaId/Feature. []***] Currently Azure requires registration (docs) for Azure OpenAI Service. Can that be submitted for the subscription used in uptest, so that the e2e test can proceed? |
@mirza-src let me see if I can get that service activated on our test account. |
/test-examples="examples/cognitiveservices/deployment.yaml" |
The services have been activated on our test account now. Re-running the e2e. |
@jeanduplessis, I was looking at the code and think that changing |
This reverts commit 1a71371. Signed-off-by: Mirza Esaaf Shuja <[email protected]>
Signed-off-by: Mirza Esaaf Shuja <[email protected]>
fc4482c
to
5e500bc
Compare
/test-examples="examples/cognitiveservices/deployment.yaml" |
@mirza-src since this is your first PR you don't yet have the capability to trigger an e2e test. Once this PR is merged you'll be seen as a collaborator and then have the ability to trigger it. |
/test-examples="examples/cognitiveservices/deployment.yaml" |
@mirza-src looking good with the latest change. The maintainers are back next week and I'll ask them to give the PR a once-over before it gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your effort @mirza-src, lgtm.
Description of your changes
Added
azurerm_cognitive_deployment
resource.Changedazurerm_cognitive_account
ExternalName
fromTemplatedStringAsIdentifier
toIdentifierFromProvider
for theazurerm_cognitive_deployment
to work.Fixes #704
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
make e2e
locallymake run