Fix goroutine leak when reconciling

This patch fixes the propagation of context cancellation through the call stack. It prevents leaks of channel and goroutine from the [terraform provider][provider_code]. Closes: #538 [provider_code]: https://github.com/hashicorp/terraform-provider-google/blob/1d1a50adf64af60815b7a08ffc5e9d3e856d2e9c/google/transport/batcher.go#L117-L123 Signed-off-by: Maxime Vidori <[email protected]>
crossplane-contrib · Jun 10, 2024 · 9090afc · 9090afc
1 parent 9941c1a
commit 9090afc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/clients/gcp.go b/internal/clients/gcp.go
@@ -161,7 +161,7 @@ func configureNoForkGCPClient(ctx context.Context, ps *terraform.Setup, p schema
 	// only once and using a pointer argument here will cause
 	// race conditions between resources referring to different
 	// ProviderConfigs.
-	diag := p.Configure(context.WithoutCancel(ctx), &tfsdk.ResourceConfig{
+	diag := p.Configure(ctx, &tfsdk.ResourceConfig{
 		Config: ps.Configuration,
 	})
 	if diag != nil && diag.HasError() {