Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add missing ACM resources #617

Conversation

StupidScience
Copy link

@StupidScience StupidScience commented Sep 10, 2024

Description of your changes

This PR adds support for multiple missing ACM resources.
PR also contains terraform version bump to 5.41.0 as earliest where some of new resources were added. Let me know if you'd rather have it as separate PR.

Fixes #616

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@StupidScience StupidScience force-pushed the add-missing-acm-resources branch from b53cd7b to e9eeab6 Compare September 10, 2024 15:24
@StupidScience
Copy link
Author

/test-examples="examples/accesscontextmanager/v1beta1/serviceperimeterdryrunresource.yaml"

@StupidScience StupidScience marked this pull request as ready for review September 10, 2024 15:26
@StupidScience
Copy link
Author

/test-examples="examples/accesscontextmanager/v1beta1/serviceperimeterdryrunresource.yaml"

@StupidScience
Copy link
Author

StupidScience commented Sep 10, 2024

I noticed existing ACM resources do not necessary contain all fields that might be references and do not strictly follow rule about the fields that are represented as separate resources from contribution guide. Although changing them at the moment will likely be a breaking change.

Also some of the resources (in particular all ingress/egress policies) are supposed to be recreated on any changes, preferably with lifecycle.create_before_destroy=true that I'm not sure how to achieve with used framework.

Another concern is that all of resources cannot be tested automatically as require org-wide permissions.

Please advise on the approaches here.

@turkenf
Copy link
Collaborator

turkenf commented Sep 11, 2024

Hi @StupidScience,

Thank you for your effort. We would prefer you to handle the terraform provider upgrade in a different PR. An example PR: #593

And about adding a new resource and testing, you can follow: https://github.com/crossplane/upjet/blob/main/docs/adding-new-resource.md

@turkenf
Copy link
Collaborator

turkenf commented Oct 9, 2024

I'm closing this for now, please feel free to open separate PRs as I mentioned above.

@turkenf turkenf closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for unsupported access context manager resources
2 participants