Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add data_policy resource #668

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nilan3
Copy link
Contributor

@nilan3 nilan3 commented Dec 9, 2024

Description of your changes

Add resources for the following terraform resources:

  • google_bigquery_datapolicy_data_policy
  • google_bigquery_datapolicy_data_policy_iam_binding

Fixes #

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

image

--- PASS: kuttl (47.06s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (45.68s)
PASS
14:36:28 [ OK ] running automated tests

Signed-off-by: nilan3 <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/bigquery/v1beta1/datapolicydatapolicy.yaml"

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 9, 2024

/test-examples="examples/bigquery/v1beta1/datapolicydatapolicyiambinding.yaml"

@nilan3 nilan3 marked this pull request as ready for review December 9, 2024 15:10
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/bigquery/v1beta1/datapolicydatapolicy.yaml"

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 10, 2024

/test-examples="examples/bigquery/v1beta1/datapolicydatapolicyiambinding.yaml"

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 10, 2024

/test-examples="examples/bigquery/v1beta1/datapolicydatapolicy.yaml"

@nilan3
Copy link
Contributor Author

nilan3 commented Dec 13, 2024

@turkenf, could you help with reviewing this pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants