chore(deps): update dependency golangci/golangci-lint to v1.60.3 (master) - autoclosed

[crossplane-renovate]

This PR contains the following updates:

Package	Update	Change
golangci/golangci-lint	minor	v1.59.0 -> v1.60.3

---

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v1.60.3

Compare Source

1. Updated linters
   • gosec: from 81cda2f to ab3f6c1 (fix G115 false positives)
2. Misc.
   • Check that the Go version use to build is greater or equals to the Go version of the project

v1.60.2

Compare Source

1. Updated linters

• gofmt: update to HEAD (go1.22)
• gofumpt: from 0.6.0 to 0.7.0
• gosec: fix G602 analyzer
• gosec: from 5f0084e to 81cda2f (adds G115, G405, G406, G506, G507)
• staticcheck: from 0.5.0 to 0.5.1
• staticcheck: propagate Go version
• wrapcheck: from 2.8.3 to 2.9.0
• ⚠️ exportloopref: deprecation

v1.60.1

Compare Source

1. Updated linters
   • errorlint: from 1.5.2 to 1.6.0
   • exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)
   • fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)
   • gocognit: from 1.1.2 to 1.1.3
   • gomodguard: from 1.3.2 to 1.3.3
   • govet (printf): report non-constant format, no args
   • lll: advertise max line length instead of just reporting failure
   • revive: from 1.3.7 to 1.3.9 (new rule: comments-density)
   • sloglint: from 0.7.1 to 0.7.2
   • spancheck: from 0.6.1 to 0.6.2
   • staticcheck: from 0.4.7 to 0.5.0
   • tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)
   • testifylint: from 1.3.1 to 1.4.3 (new options: formatter, suite-broken-parallel, suite-subtest-run)
   • tparallel: from 0.3.1 to 0.3.2
   • usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)
   • wsl: from 4.2.1 to 4.4.1
   • ️⚠️ unused: remove exported-is-used option
2. Fixes
   • SARIF: sanitize level property
   • ️⚠️ typecheck issues should never be ignored
3. Documentation
   • Add link on linter without configuration
   • Remove 'trusted by' page
   • wsl update documentation of the configuration
4. misc.
   • 🎉 go1.23 support

v1.59.1

Compare Source

1. Updated linters
   • errorlint: from 1.5.1 to 1.5.2
   • gomnd: deprecated configuration compatibility
   • intrange: add style preset
   • misspell: from 0.5.1 to 0.6.0
   • sloglint: from 0.7.0 to 0.7.1
   • testifylint: from 1.3.0 to 1.3.1
   • unparam: bump to HEAD
   • usestdlibvars: from 1.25.0 to 1.26.0
2. Fixes
   • SARIF: init empty result slice
   • SARIF: issue column >= 1
3. Documentation
   • revive: update documentation of the configuration

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[crossplane-renovate]

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Earthfile

Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

              logbus | Setting organization "crossplane" and project "crossplane-runtime"
            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.22.3 | --> Load metadata golang:1.22.3 linux/amd64
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
         +go-modules | --> FROM golang:1.22.3
         +go-modules | [----------] 100% FROM golang:1.22.3�[K
         +go-modules | [          ]   0% FROM golang:1.22.3�[K
         +go-modules | �[A[----------] 100% FROM golang:1.22.3�[K
         +go-modules | --> WORKDIR /crossplane
         +go-modules | --> COPY go.mod go.sum ./
         +go-modules | --> RUN go mod download
            +go-lint | --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | golangci/golangci-lint info checking GitHub for tag 'v1.60.3'
            +go-lint | golangci/golangci-lint info found version: 1.60.3 for v1.60.3/linux/amd64
            +go-lint | golangci/golangci-lint info installed /go/bin/golangci-lint
            +go-lint | --> COPY .golangci.yml .
            +go-lint | --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if int(current.Index) >= len(array) {
            +go-lint | 			      ^
            +go-lint | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                 ^
            +go-lint | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                  ^
            +go-lint | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if len(array) <= int(current.Index) {
            +go-lint | 			                    ^
            +go-lint | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint | 		                                       ^
            +go-lint | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint | 		            ^
            +go-lint | pkg/fieldpath/paved.go:78:28: param max has same name as predeclared identifier (predeclared)
            +go-lint | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint |                            ^
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if int(current.Index) >= len(array) {
            +go-lint *failed* | 			      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                 ^
            +go-lint *failed* | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                  ^
            +go-lint *failed* | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if len(array) <= int(current.Index) {
            +go-lint *failed* | 			                    ^
            +go-lint *failed* | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint *failed* | 		                                       ^
            +go-lint *failed* | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint *failed* | 		            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:78:28: param max has same name as predeclared identifier (predeclared)
            +go-lint *failed* | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint *failed* |                            ^
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"

🛰️ Reuse cache between CI runs with Earthly Satellites! 2-20X faster than without cache. Generous free tier https://cloud.earthly.dev

File name: Earthfile

Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

              logbus | Setting organization "crossplane" and project "crossplane-runtime"
            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.22.3 | --> Load metadata golang:1.22.3 linux/amd64
         +go-modules | --> FROM golang:1.22.3
         +go-modules | [----------] 100% FROM golang:1.22.3�[K
         +go-modules | *cached* --> WORKDIR /crossplane
         +go-modules | *cached* --> COPY go.mod go.sum ./
         +go-modules | *cached* --> RUN go mod download
            +go-lint | *cached* --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | *cached* --> COPY .golangci.yml .
            +go-lint | *cached* --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if int(current.Index) >= len(array) {
            +go-lint | 			      ^
            +go-lint | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                 ^
            +go-lint | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                  ^
            +go-lint | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if len(array) <= int(current.Index) {
            +go-lint | 			                    ^
            +go-lint | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint | 		                                       ^
            +go-lint | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint | 		            ^
            +go-lint | pkg/fieldpath/paved.go:78:28: param max has same name as predeclared identifier (predeclared)
            +go-lint | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint |                            ^
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if int(current.Index) >= len(array) {
            +go-lint *failed* | 			      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                 ^
            +go-lint *failed* | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                  ^
            +go-lint *failed* | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if len(array) <= int(current.Index) {
            +go-lint *failed* | 			                    ^
            +go-lint *failed* | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint *failed* | 		                                       ^
            +go-lint *failed* | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint *failed* | 		            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:78:28: param max has same name as predeclared identifier (predeclared)
            +go-lint *failed* | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint *failed* |                            ^
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"

🛰️ Reuse cache between CI runs with Earthly Satellites! 2-20X faster than without cache. Generous free tier https://cloud.earthly.dev