Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paved.GetFloat() function #778

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/fieldpath/paved.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,20 @@ func (p *Paved) GetString(path string) (string, error) {
return s, nil
}

// GetFloat value of the supplied field path.
func (p *Paved) GetFloat(path string) (float64, error) {
v, err := p.GetValue(path)
if err != nil {
return 0, err
}

f, ok := v.(float64)
if !ok {
return 0, errors.Errorf("%s: not a number", path)
}
return f, nil
}

// GetStringArray value of the supplied field path.
func (p *Paved) GetStringArray(path string) ([]string, error) {
v, err := p.GetValue(path)
Expand Down
61 changes: 61 additions & 0 deletions pkg/fieldpath/paved_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,67 @@ func TestGetString(t *testing.T) {
}
}

func TestGetFloat(t *testing.T) {
type want struct {
value float64
err error
}
cases := map[string]struct {
reason string
path string
data []byte
want want
}{
"Number": {
reason: "It should be possible to get a field a object",
path: "number",
data: []byte(`{"number":12.0}`),
want: want{
value: 12.0,
},
},
"MetadataNumber": {
reason: "It should be possible to get a field from a nested object",
path: "metadata.number",
data: []byte(`{"metadata":{"number":100.1}}`),
want: want{
value: 100.1,
},
},
"MalformedPath": {
reason: "Requesting an invalid field path should fail",
path: "spec[]",
want: want{
err: errors.Wrap(errors.New("unexpected ']' at position 5"), "cannot parse path \"spec[]\""),
},
},
"NotANumber": {
reason: "Requesting an non-number field path should fail",
path: "metadata.name",
data: []byte(`{"metadata":{"name":"foo"}}`),
want: want{
err: errors.New("metadata.name: not a number"),
},
},
}

for name, tc := range cases {
t.Run(name, func(t *testing.T) {
in := make(map[string]any)
_ = json.Unmarshal(tc.data, &in)
p := Pave(in)

got, err := p.GetFloat(tc.path)
if diff := cmp.Diff(tc.want.err, err, test.EquateErrors()); diff != "" {
t.Fatalf("\np.GetFloat(%s): %s: -want error, +got error:\n%s", tc.path, tc.reason, diff)
}
if diff := cmp.Diff(tc.want.value, got); diff != "" {
t.Errorf("\np.GetFloat(%s): %s: -want, +got:\n%s", tc.path, tc.reason, diff)
}
})
}
}

func TestGetStringArray(t *testing.T) {
type want struct {
value []string
Expand Down
Loading