Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build break in events.rs #884

Closed
wants to merge 1 commit into from
Closed

Conversation

heaths
Copy link
Contributor

@heaths heaths commented May 4, 2024

Fixes #883

@heaths heaths requested a review from TimonPost as a code owner May 4, 2024 16:28
@joshka
Copy link
Collaborator

joshka commented May 5, 2024

Apologies, I didn't see this PR and raised #888 which is the same fix. As I've had CI workflows approved to run, I'm getting CI results on that PR. These are highlighting that there's a few problems with the recent merges (and hence I'm fixing the build incrementally as each CI step fails).

@joshka joshka mentioned this pull request May 5, 2024
@TimonPost
Copy link
Member

merged the other pr, this can be closed now right?

@TimonPost TimonPost closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build break from #862
3 participants