Use rustix instead of libc (additive only approach) #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's still probably going to be a few things to clear up based on the various OS tests for this that run in CI. |
|
It looks like |
|
(If you want help, add me to your forked repo and I will make changes) |
|
I can't add you right now (on my phone), but I wouldn't mind a hand with working out the more difficult of the two problems - what to do with the stream to fd conversion (sigwinch is the easy one). I'll take a look tomorrow sometime if you don't get it first. |
- use rustix version of sigwinch signal - add a lifetime to FileDesc and replace FileDesc::Static to FileDesc::Borrowed. This made it necessary to either add a lifetime to the libc version of FileDesc or replace all the callers with multiple paths (libc, rustix). Changing FileDesc was more straightforward. There are no usages of FileDesc found in any repo on github, so this change should be reasonably safe.
|
Changed in latest:
@notgull what do you think of this fix? |
|
@TimonPost This is probably good to have your 👀 on it now. |
TimonPost
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an purely additive alternative approach to #878. Instead of modifying the code paths that were hitting libc, this version instead adds feature gated additions (one path for not(libc), one for libc).
Closes: #847