Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/csprofiles: default duration and type for partial configuration #3038

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 30, 2024

This won't panic anymore with this profile

decisions:
 - type: ban
 - duration: 4h

but on the other hand it's a misconfiguration so we should probably quit with an error

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.3 milestone May 30, 2024
@mmetc mmetc marked this pull request as ready for review May 30, 2024 12:17
@mmetc mmetc added the kind/fix label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (659774f) to head (2ef06e6).

Files Patch % Lines
pkg/csprofiles/csprofiles.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
- Coverage   52.57%   52.55%   -0.02%     
==========================================
  Files         281      281              
  Lines       35386    35390       +4     
==========================================
- Hits        18603    18600       -3     
- Misses      14973    14977       +4     
- Partials     1810     1813       +3     
Flag Coverage Δ
bats 40.32% <50.00%> (-0.01%) ⬇️
unit-linux 34.82% <75.00%> (+<0.01%) ⬆️
unit-windows 30.96% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the incomplete-ref-decision branch 2 times, most recently from e3cbd63 to ffff501 Compare May 31, 2024 18:20
@mmetc mmetc marked this pull request as draft June 14, 2024 12:11
@mmetc mmetc force-pushed the incomplete-ref-decision branch from ffff501 to 2ef06e6 Compare June 20, 2024 08:39
@buixor buixor self-requested a review July 5, 2024 12:39
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc modified the milestones: 1.6.3, 1.6.4 Jul 15, 2024
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants