Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove unused struct fields, enable related linter #3334

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 18, 2024

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Nov 18, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.24%. Comparing base (2ab93f7) to head (b6c73a7).

❗ There is a different number of reports uploaded between BASE (2ab93f7) and HEAD (b6c73a7). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2ab93f7) HEAD (b6c73a7)
unit-windows 1 0
unit-linux 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3334       +/-   ##
===========================================
- Coverage   58.43%   41.24%   -17.20%     
===========================================
  Files         351      333       -18     
  Lines       37827    36433     -1394     
===========================================
- Hits        22106    15025     -7081     
- Misses      13817    19923     +6106     
+ Partials     1904     1485      -419     
Flag Coverage Δ
bats 41.24% <100.00%> (-0.03%) ⬇️
unit-linux ?
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant