-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stale] add OpenBSD support for generating the machine id if /etc/machine-id … #712
Conversation
…is unavailable use the hw.uuid sysctl on openbsd to get the hardware UUID in case /etc/machine-id is not available because /proc is linux-only
outside of linux GNU make is usually called gmake so let's allow overriding the MAKE variable from the environment
Hello @rnagy , thanks for your contribution! Can you also push the go.mod please ? The CI failed because of this i think :/ |
The go.mod I have has no diffs to the one in HEAD. |
Do you have a link to the documentation of the |
Anyway it seems that syscall is deprecated, so let me get back to you with another solution. |
Ok @rnagy , thanks ! |
@@ -21,6 +22,7 @@ import ( | |||
log "github.com/sirupsen/logrus" | |||
"github.com/spf13/cobra" | |||
"gopkg.in/yaml.v2" | |||
"golang.org/x/sys/unix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnagy : I reported @cuddytrippin for spam on other issues as well :/
@rnagy it seems that the build still doesn't work :/, let me know if you need any help on this |
The library used for getting the host uuid machineid does not support OpenBSD yet, I'm suggesting instead of patching crowdsec to provide the OpenBSD support in machineid Currently machineid for the 'BSD' use Read from The fallback strategy is implemented here for the BSD in machineid For the context, I started to do the same patch with https://gist.github.com/sbz/3c23c52d6817246b3682922944a9c3ba but I realized after it's not needed. |
That project seems dead, but it is worth a try... i've submitted a pull request. This ecosystem is really not good. |
Hello @rnagy , we will wait to see if they accept your PR. If not, we will integrate those changes in |
Hello @rnagy , your PR in the machineid project is still pending .. If it still the case at the end of the week, we will add your code to crowdsec directly next week. |
What if I fork that project and then you can point the build system to use that repo? |
Hello @rnagy, sorry for the delay Yes that might be a good idea :) |
…is unavailable
use the hw.uuid sysctl on openbsd to get the hardware UUID in case /etc/machine-id
is not available because /proc is linux-only