Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if geo is configured before making calls #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LaurenceJJones
Copy link
Collaborator

fix: #18

val := net.ParseIP(args[0])

if val == nil {
return nil, fmt.Errorf("invalid IP")
}

record, err := a.GeoDatabase.GetCity(&val)

if err != nil && !errors.Is(err, geo.NotValidConfig) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely can remove the error check clause since it doesnt return this case anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[geo-ip] Crashes when mmdb files are not configured
1 participant