Add annotations to LAPI deploy, Agent daemonset and secretTemplate for certificates #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions to lapi deploy and agent daemonset
github-actions
bot
added
kind/enhancement
|
Hello, We are planning to do a release early next week and we will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add values to configure
secretTemplateofcertificateresources. Also addannotationstodeploymentanddaemonsetfor lapi and agent.This is required to add specific annotations for Reloader, which is a tool providing a workaround for #133, by triggering a rollout when it detects a secret change.
/kind enhancement
/area configuration