Skip to content

Commit

Permalink
fix background.type manifest property typescript type (#916)
Browse files Browse the repository at this point in the history
* Update manifest.ts

* Update manifest.ts

* Add changeset

---------

Co-authored-by: Jack Steam <[email protected]>
  • Loading branch information
hichemfantar and jacksteamdev authored Jan 6, 2025
1 parent e990786 commit ee860e7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/tiny-moose-occur.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@crxjs/vite-plugin": patch
---

fix background.type manifest property typescript type
2 changes: 1 addition & 1 deletion packages/vite-plugin/src/node/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface WebAccessibleResourceById {

export interface ChromeManifestBackground {
service_worker: string
type?: 'module' // If the service worker uses ES modules
type?: 'module' | (string & {}) // If the service worker uses ES modules
}

export interface FirefoxManifestBackground {
Expand Down

0 comments on commit ee860e7

Please sign in to comment.