-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: unnecessary use of REST API instead of grpc-web (get_account_balance
part)
#663
Problem: unnecessary use of REST API instead of grpc-web (get_account_balance
part)
#663
Conversation
get_account_balance
)get_account_balance
part)
Codecov ReportBase: 43.83% // Head: 43.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 43.83% 43.97% +0.14%
==========================================
Files 45 46 +1
Lines 8968 8939 -29
==========================================
Hits 3931 3931
+ Misses 5037 5008 -29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8be7690
to
2f5f85e
Compare
5a49df6
to
1595083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but some binding examples (android, JS/Wasm...) may still have old URLs?
Part of issue #511 (will fix
get_account_details
in another PR)Replace REST API with
grpc-web
forget_account_balance
functions.PR Checklist:
cargo build
)cargo test
)cargo fmt -- --check --color=auto
)cargo clippy
)cargo audit
)