[BLCKCHN-203] CronosId TS client Integration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/[email protected], npm/[email protected] |
yeehan-crypto-com
changed the title
| */ | ||
| export const resolveName = async (name: string): Promise<ApiResponse<ResolveNameResponse>> => { | ||
| const chainId = Client.getChainId(); | ||
| const url = `${BASE_URL}/api/v1/cdc-developer-platform/cronosid/resolve/${name}?chainId=${chainId}`; |
There was a problem hiding this comment.
how about using encodeURIComponent for name, chainId?
| }); | ||
|
|
||
| if (!response.ok) { | ||
| const errorBody = await response.json(); |
There was a problem hiding this comment.
how about adding validation whether response is json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
https://mcoproduct.atlassian.net/browse/BLCKCHN-203
Screen.Recording.2024-12-25.at.3.15.07.PM.mov
Type of change
Checklist:
Before you submit the pull request, please review the following checklist:
Linked Issues
Mention the issues that are addressed by this PR. You can use the
#symbol to link an issue.