Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1049

Merged
merged 2 commits into from
Jul 18, 2024
Merged

chore: fix some comments #1049

merged 2 commits into from
Jul 18, 2024

Conversation

todaymoon
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

fix some comments

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@todaymoon todaymoon requested a review from a team as a code owner June 9, 2024 09:14
@mmsqe
Copy link
Contributor

mmsqe commented Jun 10, 2024

@todaymoon can you sign the commit?

Signed-off-by: todaymoon <[email protected]>
@todaymoon
Copy link
Contributor Author

@todaymoon can you sign the commit?

Of course. Signed.

Please review again

@mmsqe mmsqe enabled auto-merge July 18, 2024 11:25
@mmsqe mmsqe added this pull request to the merge queue Jul 18, 2024
Merged via the queue into crypto-org-chain:master with commit 7598bc4 Jul 18, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants