Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest hermes is not used in integration tests #1062

Closed
wants to merge 3 commits into from

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 19, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe requested a review from a team as a code owner July 19, 2024 01:13
Copy link

socket-security bot commented Jul 19, 2024

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.85%. Comparing base (7598bc4) to head (19640c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
- Coverage   32.98%   32.85%   -0.13%     
==========================================
  Files         128      122       -6     
  Lines       20009    16514    -3495     
==========================================
- Hits         6600     5426    -1174     
+ Misses      12353    10040    -2313     
+ Partials     1056     1048       -8     
Flag Coverage Δ
integration_tests 22.60% <ø> (+1.52%) ⬆️
integration_tests_byzantine 10.19% <ø> (+0.24%) ⬆️
integration_tests_gov 10.56% <ø> (+0.26%) ⬆️
integration_tests_grpc 10.56% <ø> (+0.26%) ⬆️
integration_tests_ibc 26.93% <ø> (+1.77%) ⬆️
integration_tests_ledger 10.45% <ø> (+0.26%) ⬆️
integration_tests_slow 10.45% <ø> (+0.26%) ⬆️
integration_tests_solomachine 10.22% <ø> (+0.24%) ⬆️
integration_tests_upgrade 10.56% <ø> (+0.26%) ⬆️
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe requested a review from yihuang July 19, 2024 03:13
@mmsqe mmsqe closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant