Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: NodeURI is not set for clientCtx in test #198

Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jan 3, 2024

For more info


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mmsqe mmsqe marked this pull request as ready for review January 3, 2024 02:12
@mmsqe mmsqe requested a review from yihuang January 3, 2024 02:13
@mmsqe mmsqe force-pushed the release/v0.47.x_node_uri branch from 93556bd to cefc4ed Compare January 3, 2024 06:34
@mmsqe mmsqe changed the title Problem: rpc listen address is set for clientCtx in test Problem: NodeURI is not set for clientCtx in test Jan 3, 2024
@mmsqe mmsqe merged commit c887e86 into crypto-org-chain:release/v0.47.x Jan 3, 2024
16 of 24 checks passed
@mmsqe mmsqe deleted the release/v0.47.x_node_uri branch February 28, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants