Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no API to use the new CoW branch store #243

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 1, 2024

Description

Add RunAtomic function to context and cachemulti.Store.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@yihuang yihuang requested a review from mmsqe April 1, 2024 03:22
@yihuang yihuang force-pushed the cleanup-store-api branch from 9260c0f to 6defa84 Compare April 1, 2024 03:24
Comment on lines +202 to +203
for k, v := range other.stores {
cms.stores[k].(types.BranchStore).Restore(v.(types.BranchStore))
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@yihuang yihuang enabled auto-merge (squash) April 1, 2024 06:36
add unit test
@yihuang yihuang force-pushed the cleanup-store-api branch from 68966a1 to 6f8469e Compare April 1, 2024 06:37
@yihuang yihuang merged commit 7d01116 into crypto-org-chain:release/v0.50.x Apr 1, 2024
42 of 45 checks passed
@yihuang yihuang deleted the cleanup-store-api branch April 1, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants