Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: store key type assertion is incorrect #244

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 1, 2024

fix and add test

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@yihuang yihuang requested a review from mmsqe April 1, 2024 07:40
@yihuang yihuang force-pushed the cleanup-store-api branch from 37adc20 to d493f20 Compare April 1, 2024 07:58
@yihuang yihuang enabled auto-merge (squash) April 1, 2024 07:58
@yihuang yihuang merged commit 77efecc into crypto-org-chain:release/v0.50.x Apr 1, 2024
42 of 45 checks passed
@yihuang yihuang deleted the cleanup-store-api branch April 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants