Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fix of performance regression after upgrade in iavl is not included #1720

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 13, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes

    • Updated changelog to document a performance regression fix related to the iavl module.
  • Chores

    • Updated dependency versions and replaced certain modules to consolidate under the crypto-org-chain namespace.

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""

Walkthrough

This pull request involves updating the CHANGELOG.md with a new bug fix entry and modifying the go.mod file to update and replace several dependencies. The changes focus on updating the iavl module version and consolidating dependencies under the crypto-org-chain namespace. The modifications aim to improve dependency management and document a recent performance-related bug fix.

Changes

File Change Summary
CHANGELOG.md Added a new bug fix entry for version 1.4.1, dated December 9, 2024, related to performance regression in the iavl module
go.mod - Updated github.com/cosmos/iavl from v1.2.2 to v1.2.3
- Replaced multiple dependencies with crypto-org-chain versions, including:
- cosmossdk.io/store
- cosmossdk.io/x/tx
- github.com/cosmos/cosmos-sdk
- github.com/99designs/keyring
- github.com/cometbft/cometbft
- github.com/ethereum/go-ethereum
- github.com/evmos/ethermint
- github.com/tidwall/btree

Possibly related PRs

Suggested reviewers

  • thomas-nguy

Poem

🐰 Hop, hop, dependencies dance!
Modules swap with a cryptic glance
IAVL's version takes a leap
Crypto-org's changes run deep
A changelog's tale, version's delight
Dependencies aligned just right! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.56%. Comparing base (a3c2f70) to head (f0498de).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1720       +/-   ##
===========================================
+ Coverage   16.87%   35.56%   +18.68%     
===========================================
  Files          72      126       +54     
  Lines        6163    11915     +5752     
===========================================
+ Hits         1040     4237     +3197     
- Misses       5000     7254     +2254     
- Partials      123      424      +301     

see 71 files with indirect coverage changes

@mmsqe mmsqe changed the title Problem: query with iavl legacy iterator is not tested Problem: fix of performance regression after upgrade in iavl is not included Dec 17, 2024
@mmsqe mmsqe marked this pull request as ready for review December 17, 2024 01:17
@mmsqe mmsqe requested a review from a team as a code owner December 17, 2024 01:17
@mmsqe mmsqe requested review from yihuang and leejw51crypto and removed request for a team December 17, 2024 01:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

9-12: Consider moving version and date information

The date and version information appears to be misplaced under the "UNRELEASED" section. These details should be associated with the v1.4.1 release below.

# Changelog

## UNRELEASED

### Bug Fixes

* [#1720](https://github.com/crypto-org-chain/cronos/pull/1720) Include the fix of performance regression after upgrade in iavl.

-*Dec 9, 2024*
-
-v1.4.1
-

## v1.4.1

+*Dec 9, 2024*
+
🧰 Tools
🪛 Markdownlint (0.37.0)

9-9: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ec2a30 and f0498de.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • go.mod (1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md

13-13: null
Multiple headings with the same content

(MD024, no-duplicate-heading)


9-9: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (2)
go.mod (1)

92-92: LGTM: IAVL dependency update to fix performance regression

The update of github.com/cosmos/iavl from v1.2.2 to v1.2.3 aligns with the changelog entry and addresses the performance regression issue.

CHANGELOG.md (1)

7-8: LGTM: Well-formatted changelog entry

The changelog entry is properly formatted, references the correct PR #1720, and clearly describes the purpose of the change.

@yihuang yihuang added this pull request to the merge queue Dec 17, 2024
Merged via the queue into crypto-org-chain:main with commit 7a21109 Dec 17, 2024
44 checks passed
mmsqe added a commit to mmsqe/cronos that referenced this pull request Dec 17, 2024
…ncluded (crypto-org-chain#1720)

* Problem: query with iavl legacy iterator is not tested

call_trace

cleanup

* test fix

* add assert

* add go

* update deps

* revert test
mmsqe added a commit that referenced this pull request Dec 17, 2024
…ncluded (#1720) (#1721)

* Problem: query with iavl legacy iterator is not tested

call_trace

cleanup

* test fix

* add assert

* add go

* update deps

* revert test
@coderabbitai coderabbitai bot mentioned this pull request Dec 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants