-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: fix of performance regression after upgrade in iavl is not included #1720
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." WalkthroughThis pull request involves updating the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ae4708a
to
d3162ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
===========================================
+ Coverage 16.87% 35.56% +18.68%
===========================================
Files 72 126 +54
Lines 6163 11915 +5752
===========================================
+ Hits 1040 4237 +3197
- Misses 5000 7254 +2254
- Partials 123 424 +301 |
d3162ae
to
4950618
Compare
call_trace cleanup
99c5eee
to
1bcd882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
9-12
: Consider moving version and date informationThe date and version information appears to be misplaced under the "UNRELEASED" section. These details should be associated with the v1.4.1 release below.
# Changelog ## UNRELEASED ### Bug Fixes * [#1720](https://github.com/crypto-org-chain/cronos/pull/1720) Include the fix of performance regression after upgrade in iavl. -*Dec 9, 2024* - -v1.4.1 - ## v1.4.1 +*Dec 9, 2024* +🧰 Tools
🪛 Markdownlint (0.37.0)
9-9: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)go.mod
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md
13-13: null
Multiple headings with the same content
(MD024, no-duplicate-heading)
9-9: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (2)
go.mod (1)
92-92
: LGTM: IAVL dependency update to fix performance regression
The update of github.com/cosmos/iavl
from v1.2.2 to v1.2.3 aligns with the changelog entry and addresses the performance regression issue.
CHANGELOG.md (1)
7-8
: LGTM: Well-formatted changelog entry
The changelog entry is properly formatted, references the correct PR #1720, and clearly describes the purpose of the change.
…ncluded (crypto-org-chain#1720) * Problem: query with iavl legacy iterator is not tested call_trace cleanup * test fix * add assert * add go * update deps * revert test
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Chores