Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: block-stm is not integrated from sdk #564

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 11, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes missing coverage. Please review.

Project coverage is 46.37%. Comparing base (eac770f) to head (67986bd).

Files with missing lines Patch % Lines
app/executor.go 0.00% 13 Missing ⚠️
app/app.go 28.57% 10 Missing ⚠️
server/config/config.go 0.00% 2 Missing ⚠️
x/evm/types/response.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #564      +/-   ##
===========================================
+ Coverage    46.18%   46.37%   +0.19%     
===========================================
  Files          181      181              
  Lines        18151    18067      -84     
===========================================
- Hits          8383     8379       -4     
+ Misses        9048     8969      -79     
+ Partials       720      719       -1     
Files with missing lines Coverage Δ
server/flags/flags.go 50.00% <ø> (ø)
x/evm/types/response.go 0.00% <0.00%> (ø)
server/config/config.go 30.45% <0.00%> (+0.55%) ⬆️
app/app.go 77.23% <28.57%> (-0.60%) ⬇️
app/executor.go 0.00% <0.00%> (-2.73%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant