Problem: has operation could be more efficient than get #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - validate has operation differently. - update readme.
yihuang
commented
Apr 10, 2024
yihuang
changed the title
Signed-off-by: yihuang <[email protected]>
mmsqe
reviewed
Apr 10, 2024
| } | ||
|
|
||
| // record the has descriptor, has operation is validated by value rather than version. | ||
| s.readSet.Hases = append(s.readSet.Hases, HasDescriptor{ |
There was a problem hiding this comment.
not sure why we record has, won't we have append bigger readSet when call has operation?
| return false | ||
| } | ||
| exists := !d.isZero(value) | ||
| if exists != desc.Exists { |
There was a problem hiding this comment.
and not sure why we need loop and compare exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
TODO: