-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize secret-service library #26
Comments
Afaik this is regardless of visibility. Maybe we should just fork it temporarily. |
I take time tomorrow to solve this: swiesend/secret-service#7 but I won't find time to write the https://github.com/cryptomator/integrations-linux part. |
No worries, nothing to do in this lib on your part. We don't necessarily need swiesend/secret-service#7. This would of course be a nice improvement, but is not blocking us from anything. |
Since merge of #18, this project is modularized. All dependencies except one are named modules.
The odd one out is
de.swiesend:secret-service
. There are attempts to modularize it (see swiesend/secret-service#40), but until then this dependency is included as an automatic module. Since there is no encapsulation in an automatic module, all packages (internal or not) are exposed. This can cause split packages.We should work towards a solution (fixing or forking upstream) to avoid this trap.
The text was updated successfully, but these errors were encountered: