Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize secret-service library #26

Closed
infeo opened this issue Jul 26, 2023 · 3 comments · Fixed by #32
Closed

Modularize secret-service library #26

infeo opened this issue Jul 26, 2023 · 3 comments · Fixed by #32

Comments

@infeo
Copy link
Member

infeo commented Jul 26, 2023

Since merge of #18, this project is modularized. All dependencies except one are named modules.

The odd one out is de.swiesend:secret-service. There are attempts to modularize it (see swiesend/secret-service#40), but until then this dependency is included as an automatic module. Since there is no encapsulation in an automatic module, all packages (internal or not) are exposed. This can cause split packages.

We should work towards a solution (fixing or forking upstream) to avoid this trap.

@overheadhunter
Copy link
Member

Since there is no encapsulation in an automatic module, all packages (internal or not) are exposed. This can cause split packages.

Afaik this is regardless of visibility.

Maybe we should just fork it temporarily.

@swiesend
Copy link
Contributor

I take time tomorrow to solve this: swiesend/secret-service#7 but I won't find time to write the https://github.com/cryptomator/integrations-linux part.

@overheadhunter
Copy link
Member

No worries, nothing to do in this lib on your part. We don't necessarily need swiesend/secret-service#7. This would of course be a nice improvement, but is not blocking us from anything.

@overheadhunter overheadhunter linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants