Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to secret service 2.0.0-alpha #32

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update to secret service 2.0.0-alpha #32

merged 1 commit into from
Oct 16, 2023

Conversation

purejava
Copy link
Contributor

@purejava purejava commented Oct 3, 2023

@purejava
Copy link
Contributor Author

purejava commented Oct 3, 2023

Hints on how I tested the change can be found in this comment.

@purejava
Copy link
Contributor Author

purejava commented Oct 3, 2023

Tested with feature/jdk21 merged into develop.

overheadhunter
overheadhunter approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@overheadhunter overheadhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving this a test run. Changes look reasonable

@overheadhunter overheadhunter added this to the 1.4.0 milestone Oct 4, 2023
@overheadhunter overheadhunter linked an issue Oct 4, 2023 that may be closed by this pull request
Modularize secret-service library #26
Closed
@overheadhunter overheadhunter merged commit abd4d70 into cryptomator:develop Oct 16, 2023
2 checks passed
@purejava purejava deleted the secret-service-2.0.0-alpha branch July 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overheadhunter overheadhunter overheadhunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Modularize secret-service library
2 participants
@purejava @overheadhunter