Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add 404.html page #11428

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Nov 10, 2021

This patch adds a simple 404 error page to the generated API docs.

Ref: crystal-lang/crystal-website#118

grafik

Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

For sure we will be able to improve it, but it's good enough to include it ASAP.

src/compiler/crystal/tools/doc/html/404.html Show resolved Hide resolved
@straight-shoota straight-shoota marked this pull request as ready for review November 10, 2021 15:13
@beta-ziliani beta-ziliani added this to the 1.3.0 milestone Nov 29, 2021
@straight-shoota straight-shoota merged commit baf5c3b into crystal-lang:master Nov 30, 2021
@straight-shoota straight-shoota deleted the feature/docs-404 branch November 30, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants