-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container improvements #89
Merged
anishnaik
merged 17 commits into
crytic:dev-update-ganache
from
elopez:docker-improvements
Jul 6, 2022
Merged
Docker container improvements #89
anishnaik
merged 17 commits into
crytic:dev-update-ganache
from
elopez:docker-improvements
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions depend on the deprecated ethereum-* libraries instead of the newer eth-*, which cause a deprecation notice.
Manticore 0.3.6 causes issues when running etheno, see issue crytic#80 for the details.
This is done automatically in Dockerfiles
get.parity.io does not exist anymore
The upstream bug in ganache-cli appears to have been fixed.
This fixes an issue with the dockerfile getting stuck when installing tzdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some improvements towards #70 - image size is reduced to ~930MB from ~1.6GB, hopefully maintaining the same functionality. Based on the branch from #87, to have working binaries.
The GitHub Action has been modified slightly to build the new image and push it to GHCR. In the long run it would be nice to align with other crytic projects (e.g. changes in crytic/echidna#706)
Change list:
locales-all
to save space.To test, you can pull the image from my repository fork: https://github.com/elopez/etheno/pkgs/container/etheno%2Fetheno/12526424?tag=testing