perf: cache codehash to speedup coverage tracking #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samalws-tob
requested review from
Xenomega,
anishnaik and
0xalpharush
as code owners
samalws-tob
force-pushed
the
cache-codehash-2
branch
3 times, most recently
from
80bb56b
to
9742681
Compare
samalws-tob
force-pushed
the
cache-codehash-2
branch
from
9742681
to
6671159
Compare
0xalpharush
changed the title
0xalpharush
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache for
getContractCoverageMapHashresults, so that the operation doesn't need to be done every opcode. In benchmarks this improves performance by 50%-100%. See also #451