Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW2-7-move-social-media-to-footer #10

Merged
merged 5 commits into from
May 19, 2024

Conversation

andrew-l3
Copy link
Collaborator

Why the changes are required?

As specified.

Changes

  • [Met Req] Don’t worry about WeChat, don’t use anymore
  • [Met Req] Maybe leave social media section, just add the social media to footer (not including facebook group, facebook page is good enough)

Screenshots

request

Comments

@andrew-l3 andrew-l3 requested a review from derekxu04 April 21, 2024 05:57
Copy link
Collaborator

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review but looks good! Feel free to resolve conflicts and merge.

Details that can be discussed later unless you feel strongly about it

  • Do we want links to open a new tab? I'm leaning towards yes
  • Definitely want to make the links (and the general footer bigger probably), but this can be left to later probably

@andrew-l3 andrew-l3 merged commit 4a359ad into master May 19, 2024
1 check failed
PenTest-duck pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants