CW2-5 Sponsors Page Draft/Template #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu04
requested changes
Apr 6, 2024
There was a problem hiding this comment.
Looks good!
Suggestions:
- I don't really like the background they've used for the sponsors card, also they seem to have used all white company logos, it is fine to leave as now if we want to come back and choose a specific look later
- Adding a sponsorInfo (or similar) type to
data.ts
Changes:
- Clicking "resources" > clicking "about us" doesn't work
- this is annoying because some sections direct to sections on landing page vs sponsors to its own separate page, I think we just end up making pages for each section but to be confirmed
- "View our sponsors" button on main landing page does not redirect to sponsors page
- Change the "C:\INTERNAL STRUCTURE" text depending on which page we are on
derekxu04
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
LGTM
I've merged master and made a small changes to data.ts and some other files for linting purposes. @andrew-l3 if my changes look all good happy for you to merge
PenTest-duck
pushed a commit
that referenced
this pull request
May 30, 2024
CW2-5 Sponsors Page Draft/Template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMS-299 A brief summary of the ticket
Why the changes are required?
Creation of the sponsors subpage. A simple template at this stage, containing the current sponsor list (from the mainpage) and categorised as listed. Styling and general theme to be changed in the future.
Changes
Completed the following:
Screenshots
Comments
Links have been obtained from each sponsor's main webpage (further confirmation required). Logos have been obtained from google drive where possible (otherwise from the active main site). Logo's have not been filtered at this stage (i.e. further guidelines are required to proceed).