[CMS-307] #295
[CMS-307] #295
Conversation
hdphuong
commented
Oct 18, 2022
hdphuong
commented
- test for UploadDocument - lots of "inspiration" from test for UploadImage
- move EditType into Operations
There was a problem hiding this comment.
The Go part of it looks good but theres also some TS code that needs to be updated too: https://github.com/csesoc/website/blob/main/backend/editor/OT/OTClient/operation.ts
There was a problem hiding this comment.
Refer to comments + also I feel like this PR introduces a discontinuity between how TS will parse incoming operation payloads and how Go will.
Your types for TS seem to suggest that opType is of type "insert" | "delete" while for Go it is simply an integer, its been a while since I've looked at this so I may be wrong
| transformAgainst = (op: AtomicOperation): AtomicOperation[] => [this, op]; | ||
| } | ||
|
|
||
| export class BooleanOperation implements AtomicOperation { | ||
| type = "booleanOperation"; | ||
| newValue: boolean; | ||
| constructor(newValue: boolean) { | ||
| opType: "insert" | "delete"; | ||
| constructor(newValue: boolean, opType: "insert" | "delete") { |
There was a problem hiding this comment.
There is a lot of unneeded duplication here, abstract this out into its own type:
type OperationType = "insert" | "delete";
export class BooleanOperation implements AtomicOperation {
type = "booleanOperation";
newValue: boolean;
constructor(newValue: boolean) {
opType: OperationType;
constructor(newValue: boolean, opType: OperationType) {
// ....
}
}There was a problem hiding this comment.
wait i thought that's what i'm supposed to do according to this jira ticket?
backend/editor/OT/operations/tests/operation_application_test.go
Outdated
Show resolved
Hide resolved
