Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-25] Published blog title is name of file in CMS #379

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brian2w
Copy link
Contributor

@brian2w brian2w commented Jul 19, 2023

Why the changes are required?

Currently, the title of the blog is in the next.js app is hard coded as "Blog Title", as the file name was note being passed into the BlogPage component in [bid].tsx.

Changes

  • To obtain the file name in the [bid].tsx component, I have made an additional fetch request in the getServerSideProps function to the backend route http://backend:8080/api/filesystem/info.
  • I've then added an additional property to the parameters of the BlogPage component.

Screenshots

image
image

Comments

@brian2w brian2w requested review from lauraw0 and jamest0 as code owners July 19, 2023 01:37
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeee merge whenever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants