Merge pull request #28 from tanhongit/develop

some update v2

.github/workflows/deploy_test.yml

@@ -16,7 +16,7 @@ jobs:
   deploy_test:
     name: Deploy to Test Server
     runs-on: self-hosted
-    # needs: shellcheck
+    needs: shellcheck
     steps:
       - name: Deploy to Remote Host
         uses: appleboy/ssh-action@master
@@ -29,4 +29,4 @@ jobs:
             cd /home/tannp/telegram-bot-github-notify
             git reset --hard HEAD
             git pull origin main
-            composer install
+            composer update

composer.json

@@ -12,6 +12,7 @@
     "github-notifier",
     "github-telegram-bot"
   ],
+  "type": "project",
   "homepage": "https://github.com/tanhongit/telegram-bot-github-notify",
   "license": "MIT",
   "require": {

src/Services/TelegramService.php

@@ -25,32 +25,31 @@ public function __construct()
     /**
      * @return void
      */
-    public function setToken(): void
+    private function setToken(): void
     {
         $this->token = config('telegram-bot.token');
     }
 
     /**
      * @return void
      */
-    public function setChatId(): void
+    private function setChatId(): void
     {
         $this->chatId = config('telegram-bot.chat_id');
     }
 
     /**
-     * @return Telegram
+     * @return void
      */
-    public function storeByToken(): Telegram
+    private function storeByToken(): void
     {
         $this->telegram = new Telegram($this->token);
-        return $this->telegram;
     }
 
     /**
      * @return void
      */
-    public function getDataOfMessage(): void
+    private function getDataOfMessage(): void
     {
         $this->messageData = $this->telegram->getData() ?? [];
     }
@@ -149,7 +148,7 @@ public function telegramToolHandler(string $text = null): void
      * @param string|null $callback
      * @return void
      */
-    public function sendCallbackResponse(string $callback = null): void
+    protected function sendCallbackResponse(string $callback = null): void
     {
         if (!empty($callback) && $callback == 'about') {
             $reply = "Thanks for using our bot.\n\nThe bot is designed to send notifications based on GitHub events from your github repo instantly to your Telegram account.";