add detection for env() functions
#921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
changed the title
env() functions
| @@ -0,0 +1,7 @@ | |||
| @media (min-height: calc((safe-area-inset-top) + 0.02px)) {} | |||
There was a problem hiding this comment.
Just curious here, why is it 0.02 and not 0.01 ? Is that the limit?
There was a problem hiding this comment.
0.02 is the smallest fraction that works well for some older Safari versions.
This is something that was tested by bootstrap and reported to postcss-media-minmax.
Anything smaller than 0.02 is rounded away.
So 900.01 === 900 but 900.02 !== 900
There was a problem hiding this comment.
romainmenke
deleted the
add-detection-for-env-funciton--passionate-newt-86807acb8b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff like this should be supported in browsers :
@media (height > env(safe-area-inset-top)) {}But I don't know how to test this in a browser to verify.
Anyone knows what the magic incantation is to get
env(safe-area-inset-top)be not0?https://w3c.github.io/csswg-drafts/css-env/#env-function:~:text=Because%20environment%20variables%20don%E2%80%99t%20depend%20on%20the%20value%20of%20anything%20drawn%20from%20a%20particular%20element%2C%20they%20can%20be%20used%20in%20places%20where%20there%20is%20no%20obvious%20element%20to%20draw%20from%2C%20such%20as%20in%20%40media%20rules%2C%20where%20the%20var()%20function%20would%20not%20be%20valid.