Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support astropy 7.0 #2639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support astropy 7.0 #2639

wants to merge 1 commit into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 7, 2024

No description provided.

@maxnoe maxnoe marked this pull request as draft November 7, 2024 15:08

This comment has been minimized.

@maxnoe maxnoe changed the title Test on astropy 7rc1 Support astropy 7.0 Nov 22, 2024
@maxnoe maxnoe marked this pull request as ready for review November 22, 2024 09:56

This comment has been minimized.

2 similar comments

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (94.10% Estimated after merge)
  • Duplications No duplication information (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@Tobychev
Copy link
Contributor

The changelog says "Add support" but actually nothing was added (because we were already compatible?) which I find a bit surprising given the description. Can't think of a another way to word it that's worth using though...

@maxnoe
Copy link
Member Author

maxnoe commented Nov 22, 2024

The requirements excluded astropy 7 before.

We got lucky that we didn't have to change anything on a major version release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants