Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging failure does not make job fail #394

Closed
vuillaut opened this issue Feb 28, 2023 · 0 comments · Fixed by #398 or #399
Closed

Merging failure does not make job fail #394

vuillaut opened this issue Feb 28, 2023 · 0 comments · Fixed by #398 or #399

Comments

@vuillaut
Copy link
Member

vuillaut commented Feb 28, 2023

@vuillaut It seems other base productions have the same issue:
20221215_v0.9.12_base_prod and 20230127_v0.9.12_base_prod_az_tel

Originally posted by @SeiyaNozaki in #371 (comment)

See e.g.
/fefs/aswg/data/mc/DL1/AllSky/20221215_v0.9.12_base_prod/TrainingDataset/dec_931/Protons/merging-output.e

Traceback (most recent call last):
  File "/fefs/aswg/software/conda/envs/lstchain-v0.9.12/bin/lstchain_merge_hdf5_files", line 8, in <module>
    sys.exit(main())
  File "/fefs/aswg/software/conda/envs/lstchain-v0.9.12/lib/python3.8/site-packages/lstchain/scripts/lstchain_merge_hdf5_files.py", line 88, in main
    auto_merge_h5files(
  File "/fefs/aswg/software/conda/envs/lstchain-v0.9.12/lib/python3.8/site-packages/lstchain/io/io.py", line 341, in auto_merge_h5files
    out_node.append(in_node.read().astype(out_node.dtype))
ValueError: structures must have the same size
vuillaut added a commit that referenced this issue Apr 14, 2023
Fixes #394

* make sure that all jobs check the exit code before continuing

* working with exit

* fix unit test

* fix bug in unit test log file
@vuillaut vuillaut reopened this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant