Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that all jobs check the exit code before continuing #398

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

vuillaut
Copy link
Member

Fixes #394

@vuillaut vuillaut marked this pull request as ready for review April 14, 2023 16:43
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (825c042) 30.60% compared to head (e2b0c6b) 30.65%.

❗ Current head e2b0c6b differs from pull request most recent head 14be2e7. Consider uploading reports for the commit 14be2e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   30.60%   30.65%   +0.05%     
==========================================
  Files          46       46              
  Lines        2774     2776       +2     
==========================================
+ Hits          849      851       +2     
  Misses       1925     1925              
Impacted Files Coverage Δ
lstmcpipe/tests/test_utils.py 95.94% <100.00%> (ø)
lstmcpipe/utils.py 81.71% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuillaut vuillaut merged commit c2340d1 into master Apr 14, 2023
@vuillaut vuillaut deleted the exit_code branch April 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging failure does not make job fail
1 participant