Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the dependencies afterok should be given with : #399

Merged
merged 1 commit into from
Apr 16, 2023
Merged

the dependencies afterok should be given with : #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lstmcpipe/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def test_sbatch_lst_mc_stage():

sbatch.extra_slurm_options = None
sbatch.slurm_dependencies = "123,243,345,456"
assert sbatch._construct_slurm_dependencies() == "--dependency=afterok:123,243,345,456"
assert sbatch._construct_slurm_dependencies() == "--dependency=afterok:123:243:345:456"

sbatch.compose_wrap_command(
wrap_command="python args",
Expand Down
2 changes: 1 addition & 1 deletion lstmcpipe/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def _construct_slurm_dependencies(self):
if slurm_deps is None or slurm_deps == "":
return ""
elif all(items != "" for items in slurm_deps.split(",")):
return f"--dependency={dependency_type}:{slurm_deps}"
return f"--dependency={dependency_type}:{slurm_deps.replace(',',':')}"
else:
raise ValueError("Slurm dependencies contain an empty value between commas, i.e.; ,'', ")

Expand Down