Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ctfd_challenge.attribution after CTFd update to v3.7.5 #140

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Add ctfd_challenge.attribution after CTFd update to v3.7.5 #140

merged 1 commit into from
Dec 28, 2024

Conversation

pandatix
Copy link
Member

This PR updates CTFd to v3.7.5, thus fixes the ctfd_challenge.attribution problem.

@pandatix pandatix added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file go Pull requests that update Go code github_actions Pull requests that update GitHub Actions code labels Dec 28, 2024
@pandatix pandatix requested a review from NicoFgrx December 28, 2024 12:09
@coveralls
Copy link

coveralls commented Dec 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12526557336

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 70.19%
Totals Coverage Status
Change from base Build 12471534166: 0.2%
Covered Lines: 1481
Relevant Lines: 2110
💛 - Coveralls

pandatix added a commit that referenced this pull request Dec 28, 2024
@pandatix
chore: reflect updates of #140
39c0541
pandatix added a commit that referenced this pull request Dec 28, 2024
@pandatix
chore: reflect updates of #140
1b2604a
@pandatix pandatix force-pushed the impr/challenge-attribution branch from c42a5a7 to 9afcdc9 Compare December 28, 2024 12:23
NicoFgrx
NicoFgrx approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit 7778928 into main Dec 28, 2024
6 checks passed
@pandatix pandatix deleted the impr/challenge-attribution branch December 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoFgrx NicoFgrx NicoFgrx approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pandatix @coveralls @NicoFgrx