debug metrics collection

ctrox · Sep 28, 2024 · 2f96321 · 2f96321
1 parent bd82068
commit 2f96321
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/e2e/setup_test.go b/e2e/setup_test.go
@@ -705,11 +705,15 @@ func getNodeMetrics(c client.Client, cfg *rest.Config) (map[string]*dto.MetricFa
 	if err != nil {
 		return nil, err
 	}
+	b, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return nil, err
+	}
 
 	var parser expfmt.TextParser
-	mfs, err := parser.TextToMetricFamilies(resp.Body)
+	mfs, err := parser.TextToMetricFamilies(bytes.NewReader(b))
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("reading metrics body: %s", b)
 	}
 
 	return mfs, nil

diff --git a/manager/metrics_collector.go b/manager/metrics_collector.go
@@ -2,6 +2,7 @@ package manager
 
 import (
 	"context"
+	"fmt"
 	"io"
 	"log/slog"
 	"net"
@@ -39,6 +40,7 @@ func fetchMetricsAndMerge(w io.Writer) {
 		shimMetrics, err := getMetricsOverTTRPC(context.Background(), sockName)
 		if err != nil {
 			slog.Error("getting metrics", "err", err)
+			fmt.Fprintf(w, "getting metrics error: %s", err)
 			// we still want to read the rest of the sockets
 			continue
 		}